vminitd: Strip binaries #464
Merged
+13
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
force-pushed
the
strip-binaries
branch
4 times, most recently
from
e8b60bb to
a7ea283
Compare
We don't need the symbols, and it gives us a 70% reduction in
size...
FILE SIZE VM SIZE
-------------- --------------
26.9% 64.4Mi 50.7% 37.3Mi [258604 Others]
16.8% 40.2Mi 0.0% 0 [section .debug_info]
13.0% 31.1Mi 42.2% 31.1Mi icudt74_dat
11.2% 26.9Mi 0.0% 0 [section .debug_str]
7.0% 16.7Mi 0.0% 0 [section .debug_loc]
6.4% 15.4Mi 0.0% 0 [section .debug_ranges]
4.9% 11.6Mi 0.0% 0 [section .debug_names]
4.5% 10.7Mi 0.0% 0 [section .debug_line]
2.4% 5.72Mi 0.0% 0 [section .debug_loclists]
1.4% 3.28Mi 0.0% 0 [section .debug_str_offsets]
1.2% 2.80Mi 0.0% 0 [section .debug_abbrev]
0.7% 1.61Mi 0.0% 0 [section .debug_addr]
dcantah
force-pushed
the
strip-binaries
branch
from
a7ea283 to
2d7d4e6
Compare
dcantah
commented
Jan 1, 2026
| return stats | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Context: Seems github by default creates a merge commit when checking out the repo for CI. hawkeye then checks what date the merge commit was made and gets tripped up and modifies the files in the last commit (before the one in this PR) to be 2025-2026. We could change to just checking out the commit directly, but I don't want to do that in this change. Just slightly modifying these so CI and local agree is less hassle for now.
jglogan
approved these changes
Jan 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift release builds don't strip, and we don't need the symbols. 240Mi -> 70