TEST: do not merge — proving the libs/ guard fires - #90
Closed
hal-eisen-adfa wants to merge 2 commits into
Closed
Conversation
libs/ holds build outputs. The "Update libs from CodeOnTheGo" workflow builds them on JDK 17, the JDK every runner here uses, and pushes to main with an admin PAT that bypasses the main ruleset. A laptop on JDK 21 writes class file version 65 into gradle-plugin.jar instead; a JDK 17 runner reads only up to 61. PR #87 shipped such a jar, so "Publish addons" failed with UnsupportedClassVersionError on a tree that built fine on the machine that produced it. Every human change reaches main through a pull request, so a PR-level check closes the laptop path without touching the CI path. Claude-Session: https://claude.ai/code/session_01XWXk1HTqbD46eYmnfAMPNv
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Author
|
Guard verified: the check failed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway PR. It carries the guard from #89 plus a scratch file under
libs/. IfCheck toolchainpasses here, the guard does not work. Closing as soon as the check reports.https://claude.ai/code/session_01XWXk1HTqbD46eYmnfAMPNv