Skip to content

fix: Paginate GitHub API responses #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fnesveda merged 1 commit into from
Mar 10, 2026
+7 −3
Merged

fix: Paginate GitHub API responses #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ async function findUsersTeamName(orgOctokit, userLogin) {
const { data: childTeams } = await orgOctokit.rest.teams.listChildInOrg({
org: consts_1.ORGANIZATION,
team_slug: consts_1.PARENT_TEAM_SLUG,
per_page: 100,
});
if (!childTeams.length)
throw new Error('No child teams found!');
Expand Down Expand Up @@ -132,9 +133,10 @@ exports.assignPrCreator = assignPrCreator;
*/
async function fillCurrentMilestone(context, octokit, pullRequest, teamName) {
// Assign PR to right sprint milestone
const { data: milestones } = await octokit.request('GET /repos/{owner}/{repo}/milestones', {
const milestones = await octokit.paginate('GET /repos/{owner}/{repo}/milestones', {
owner: context.repo.owner,
repo: context.repo.repo,
per_page: 100,
});
if (milestones.length === 0)
await fail(pullRequest, 'No sprint milestone!');
Expand Down
2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion src/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export async function findUsersTeamName(orgOctokit: OctokitType, userLogin: stri
const { data: childTeams } = await orgOctokit.rest.teams.listChildInOrg({
org: ORGANIZATION,
team_slug: PARENT_TEAM_SLUG,
per_page: 100,
});
if (!childTeams.length) throw new Error('No child teams found!');

Expand Down Expand Up @@ -122,9 +123,10 @@ export async function assignPrCreator(context: Context, octokit: OctokitType, pu
*/
export async function fillCurrentMilestone(context: Context, octokit: OctokitType, pullRequest: PullRequest, teamName: string): Promise<string> {
// Assign PR to right sprint milestone
const { data: milestones } = await octokit.request('GET /repos/{owner}/{repo}/milestones', {
const milestones = await octokit.paginate('GET /repos/{owner}/{repo}/milestones', {
owner: context.repo.owner,
repo: context.repo.repo,
per_page: 100,
});
if (milestones.length === 0) await fail(pullRequest, 'No sprint milestone!');

Expand Down
Loading