Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI check for Zenhub epic linking to accommodate changes in Zenhub's API. Instead of checking for linked epics through timeline events, it now checks if a linked issue is itself an epic by querying the issue type directly.
- Adds a new GraphQL query
ZENHUB_ISSUE_TYPE_QUERYto fetch issue types from Zenhub - Implements
isIssueLinkedToEpicfunction to determine if a linked issue is an epic - Refactors
ensureCorrectLinkingAndEstimatesto use the new epic checking approach and removes dependency ongetLinkedEpics
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jirimoravcik
approved these changes
Nov 26, 2025
mtrunkat
approved these changes
Nov 28, 2025
Member
mtrunkat
left a comment
mtrunkat
left a comment
There was a problem hiding this comment.
One naming comment otherwise looks good
| /** | ||
| * Checks if the linked issue is a Zenhub epic. | ||
| */ | ||
| export async function isIssueLinkedToEpic( |
Member
There was a problem hiding this comment.
Perhaps the naming should be different, as this sounds like you are checking that the given issue is linked to the epic, but in fact, you are checking that the actual given issue is the epic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zenhub no longer performs linking to epics. We can now replace this behaviour by using the pull request connection.
This PR replaces the previous check by checking if there is a linked issue, and if it is an epic, the epic doesn't need an estimate, but the PR does instead. This lets us mark ad-hoc PRs that belong to a project using the issue connections.