tests: fix flaky tests with timing-sensitive assertions#1801
Merged
Conversation
The test_execution test expected >= 3 calls with a 30ms delay but only slept 100ms, leaving ~10ms of headroom. On loaded CI runners, asyncio scheduling jitter caused only 2 calls, failing the assertion. Doubling the sleep to 200ms provides a comfortable margin. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
On slow Windows CI, Playwright browser startup exceeded the 10s relaxed timeout, causing the browser fallback to fail. BasicCrawler then retried the request, and the retry's static crawl succeeded (using the mutated timeout), calling the static handler a second time. Fix: increase relaxed timeout to 120s for slow CI, and set max_request_retries=0 since the test validates fallback, not retries. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vdusek
added
t-tooling
github-actions
bot
added
the
tested
vdusek
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1801 +/- ##
==========================================
- Coverage 92.25% 92.23% -0.02%
==========================================
Files 157 157
Lines 10847 10847
==========================================
- Hits 10007 10005 -2
- Misses 840 842 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_execution: Increasedasyncio.sleepfrom 0.1s to 0.2s — the 30ms recurring task had only ~10ms of headroom for 3 calls, causing flakes on loaded CI runners.test_adaptive_playwright_crawler_timeout_in_sub_crawler: On slow Windows CI, Playwright browser startup exceeded the 10s relaxed timeout, causing the browser fallback to fail and trigger a retry that called the static handler twice. Fixed by increasing the relaxed timeout to 120s and settingmax_request_retries=0(test validates fallback, not retries).🤖 Generated with Claude Code