Conversation
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
652317c to
97effac
Compare
|
Preview for this PR was built for commit |
97effac to
bf23549
Compare
|
Preview for this PR was built for commit |
bf23549 to
97effac
Compare
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
@valekjo no worries! A lot of those can be now caught using our review skill for Claude-code (we might enhance them to be agent agnostic, but for now it's Claude-centric) |
|
I'll make another pass that focus more on the doc itself later today instead of low-hanging fruits |
- Update the documentation to clarify the use of multiple datasets in Actors, including definitions, requirements, and access methods - Update explanations of aliases versus named datasets and billing implications
| **Requirements:** | ||
|
|
||
| - The `datasets` object must contain the `default` alias | ||
| - The `datasets` and `dataset` objects are mutually exclusive (use one or the other) |
There was a problem hiding this comment.
It'd be great to link the actor.json reference from here so that the reader can understand the difference between dataset and datasets better.
There was a problem hiding this comment.
Do you mean the reference from docs or the publicly available schema files?
There was a problem hiding this comment.
The reference in the docs
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Show resolved
Hide resolved
|
|
||
| ### Environment variable | ||
|
|
||
| Access the environment variable directly without the SDK: |
There was a problem hiding this comment.
Maybe elaborate a bit what this will do (give you a dataset ID)
| "products": { | ||
| "type": "string", | ||
| "title": "Products", | ||
| "template": "{{storages.datasets.default.apiUrl}}/items" | ||
| }, | ||
| "categories": { | ||
| "type": "string", | ||
| "title": "Categories", | ||
| "template": "{{storages.datasets.categories.apiUrl}}/items" | ||
| } |
There was a problem hiding this comment.
So... what does this (mainly the template field) actually do?
There was a problem hiding this comment.
That should be clear from the output schema docs. Basically, this will show a dropdown (or tabs) in the Actor run Output tab, with "Products" and "Categories", and if the datasets also have some views defined, the users can switch between those too.
There was a problem hiding this comment.
Bold of you to assume that the reader saw and understood that 🙂 Maybe you could add a link to the "How templates work" section?
TC-MO
left a comment
There was a problem hiding this comment.
Second pass done focusing more on the document itself instead of low-hanging fruits.
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Outdated
Show resolved
Hide resolved
…chema/multiple_datasets.md Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
…chema/multiple_datasets.md Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
…chema/multiple_datasets.md Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
…chema/multiple_datasets.md Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
…chema/multiple_datasets.md Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
…chema/multiple_datasets.md Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
…chema/multiple_datasets.md Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
…chema/multiple_datasets.md Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
|
Preview for this PR was built for commit |
…chema/multiple_datasets.md Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
…chema/multiple_datasets.md Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
The feature is now supported in both SDKs and API docs is out - we can finally publish the respective section in docs :)