feat: build apisix-openresty base on alpine#97
Open
gxthrj wants to merge 30 commits into
Open
Conversation
spacewander
reviewed
Sep 26, 2021
spacewander
left a comment
spacewander
left a comment
Contributor
There was a problem hiding this comment.
Please check the build result in the CI
| ARG RESTY_OPENSSL_URL_BASE="https://www.openssl.org/source" | ||
| ARG RESTY_PCRE_VERSION="8.44" | ||
| ARG RESTY_J="1" | ||
| ARG RESTY_CONFIG_OPTIONS="\ |
Contributor
There was a problem hiding this comment.
Please remove unused ARG/labels
spacewander
reviewed
Oct 14, 2021
spacewander
left a comment
spacewander
left a comment
Contributor
There was a problem hiding this comment.
Could you add a workflow to verify the build?
Contributor
|
Look like we need to use glibc for Alpine? |
Contributor
Author
I used https://github.com/sgerrand/alpine-pkg-glibc , but still failed. |
spacewander
reviewed
Oct 19, 2021
| @@ -0,0 +1,55 @@ | |||
| ARG ENABLE_PROXY=false | |||
Contributor
There was a problem hiding this comment.
This file can be removed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.