Repository navigation
Conversation
apalis-core rc.11 moved the running-task registry behind its `task-context` feature (`WorkerContext::tasks` now returns a `Result`) and gave `WaitForCompletion` a `&mut self` receiver. `^1.0.0-rc.10` resolves to rc.11, so rc.9 no longer compiles in a fresh resolution. Enable `task-context` for the heartbeat's task list, surface its error as `Error::TaskState`, and take `&mut self` in `wait_for` / `check_status`.
Member
|
Thanks for this but task-tracking is an optional feature. Resolved in #119 |
Author
|
sorry, my bad. I have to put some more guardrails to my agents. Thanks for your help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
apalis-postgres1.0.0-rc.9 requiresapalis-core = "^1.0.0-rc.10", which now resolves to rc.11 — and rc.9 does not compile against it:WorkerContext::tasks()is behind apalis-core'stask-contextfeature and returns aResult(keep_alive.rs);WaitForCompletion::wait_for/check_statustake&mut self(wait_for.rs).This bumps
apalis-core/apalis-codec(and theapalis/apalis-workflowdev-dependencies) to rc.11, enablestask-contextso the heartbeat can still list the worker's running tasks, surfacesTaskStateErroras a newError::TaskStatevariant, and takes&mut selfin the twoWaitForCompletionmethods. No behaviour change.Type of Change
Testing
cargo fmtandcargo clippycargo check --all-targetsandcargo clippy --all-targetspass withSQLX_OFFLINE=true(the only warnings are the existing ones inexamples/basic.rsandexamples/unique_jobs.rs). I did not run the database-backed tests.Checklist
Additional Notes
Adding a variant to
Erroris technically an API addition; the enum is not#[non_exhaustive], so callers that match it exhaustively would need a new arm.