Repository navigation
[REFACTOR][TIRx] Declare dynamic shared memory with a CUDA leaf op - #20563
Merged
Merged
Conversation
Replace the dyn_smem_bytes attribute marker with a typed CUDA declaration. Collect the byte count for the host launch and remove the declaration from the device body while preserving pool accounting and allocation-extent fallback.
tlopex
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the dynamic shared-memory size attribute with
T.cuda.dyn_smem_bytes(bytes), a CUDA declaration whose signature requires an integer constant.SMEMPool.commit()emits the declaration, and host/device splitting collects its byte count for the runtime launch before removing it from the device body.Preserve pool high-water accounting, explicit-size precedence, allocation-extent fallback, and dynamic shared-memory launch argument ordering. Migrate direct declaration sites to the CUDA spelling.