feat: Add comparison methods to c_class decorator

[Dayuxiaoshui]

• Add eq parameter (default True) to generate eq and ne methods
• Add order parameter (default False) to generate lt, le, gt, ge methods
• Add compare parameter to field() function to control field inclusion in comparisons
• Implement method_eq, method_ne, and method_order functions in _utils.py
• Add tests for comparison functionality

The comparison methods use lexicographic comparison of fields marked with compare=True.

[gemini-code-assist]

Summary of Changes

Hello @Dayuxiaoshui, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the c_class decorator by integrating robust comparison capabilities. It allows users to define how instances of FFI-bound C++ classes are compared in Python, offering flexibility through class-level flags for equality and ordering, and field-level control to specify which attributes participate in these comparisons. This change streamlines the process of creating Pythonic interfaces for C++ types that require comparison logic.

Highlights

• Comparison Method Generation: Introduced new eq and order parameters to the c_class decorator, allowing automatic generation of __eq__, __ne__, __lt__, __le__, __gt__, and __ge__ methods for FFI-bound classes.
• Field-level Comparison Control: Added a compare parameter to the field() function, enabling fine-grained control over which fields are included in the generated comparison methods.
• Core Logic Implementation: Implemented method_eq, method_ne, and method_order functions in _utils.py to dynamically generate the Python comparison methods based on the class's fields and the new compare attribute.
• Comprehensive Testing: Added new test cases to validate the correctness and behavior of the generated equality and ordering methods, including scenarios with different field values and types.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds comparison method generation to the c_class decorator, a nice feature enhancement. The implementation correctly generates __eq__, __ne__, and ordering methods. However, there are several critical issues, including unresolved merge conflict markers in two files that will prevent the code from running. I've also identified a bug in how existing __ne__ methods are handled. Additionally, I've provided several suggestions to significantly simplify and improve the efficiency of the method generation code by using tuple comparisons and functools.total_ordering. The new tests are a good start, but they are currently ineffective or incomplete and need to be improved to properly validate the new functionality.