Fix drawboard rendering for axis-aligned shapes - #1050
Draft
sainadh777 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale and impact
A zero-width or zero-height rectangle/ellipse is not rendered by the Java2D implementation used by the drawboard example, while the browser canvas renders the corresponding user gesture as a line. The change is confined to the example application and preserves existing behavior for non-axis-aligned shapes.
Validation
ant validate— BUILD SUCCESSFULant test -Dtest.entry=org.apache.tomcat.websocket.TestDrawMessage— BUILD SUCCESSFUL; 2 tests, 0 failures, 0 errors, 0 skippedant clean— BUILD SUCCESSFULant— BUILD SUCCESSFULant teston macOS — did not qualify: Tribes multicast tests failed withNoRouteToHostException; rerun in isolated Linux as required._*.jarfilesant testrun — completed but did not qualify after the Colima VM clock corrected forward by about 13 hours mid-run, producing unrelated timeout/rate-window failures and an impossible 788-minute Ant durationant clean && ant testoneclipse-temurin:25-jdk-noble(ARM64) — BUILD SUCCESSFUL in 29m59s; 651 suite summaries, no failed suites; standard native/OpenSSL-dependent skips only--initcontainer — HTTP 200 fromhttp://127.0.0.1:8080/(11,229 bytes);shutdown.shstopped Tomcat and the JVM PID was reapedTested and pushed commit:
63bd5f30e892eb93d536a2ee27b3948c28d1b829.