TEZ-4669: Spotbugs fails in precommit

[abstractdog]

Upgraded sisu-inject-plexus that spotbugs plugin depends on to make it work (it was mainly a guesswork).

Regarding the process:

1. first took a look at: https://issues.apache.org/jira/secure/attachment/13080464/maven_build_spotbugs.log
2. found some related dependencies (to the exception reported, see in Jira):

org.sonatype.sisu:sisu-inject-plexus:jar:1.4.2:compile

3. upgrading those locally for spotbugs plugin worked

solution double-checked locally too:

find . -name "spotbugs.html"
./hadoop-shim/target/site/spotbugs.html
./tez-mapreduce/target/site/spotbugs.html
./tez-common/target/site/spotbugs.html
./tez-runtime-internals/target/site/spotbugs.html
./tez-examples/target/site/spotbugs.html
./tez-dag/target/site/spotbugs.html
./tez-runtime-library/target/site/spotbugs.html
...

[Aggarwal-Raghav]

I was also debugging this 😅. I think based on the stacktrace the issue is because of missing VelocityComponentConfigurator class used by DefaultVelocityComponent constructor

but the 1st parameter of org.codehaus.plexus.velocity.internal.DefaultVelocityComponent.<init>(Unknown Source) is not @Nullable
  at org.eclipse.sisu.wire.LocatorWiring
  while locating org.codehaus.plexus.velocity.VelocityComponentConfigurator

So, if we somehow add that class, it should work. I was going to add

jar tvf org/codehaus/plexus/plexus-velocity/2.2.1/plexus-velocity-2.2.1.jar | rg VelocityComponentConfigurator
   216 Sat Apr 05 14:56:42 IST 2025 org/codehaus/plexus/velocity/VelocityComponentConfigurator.class

[tez-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	16m 22s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ master Compile Tests _
+1 💚	mvninstall	11m 31s		master passed
+1 💚	compile	2m 34s		master passed
+1 💚	javadoc	1m 41s		master passed
			_ Patch Compile Tests _
+1 💚	mvninstall	5m 1s		the patch passed
+1 💚	codespell	1m 53s		No new issues.
+1 💚	compile	2m 33s		the patch passed
+1 💚	javac	2m 33s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	javadoc	1m 30s		the patch passed
			_ Other Tests _
+1 💚	unit	74m 17s		root in the patch passed.
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		119m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-457/1/artifact/out/Dockerfile
GITHUB PR	#457
Optional Tests	dupname asflicense javac javadoc unit codespell detsecrets xmllint compile
uname	Linux 5ee911e4fd5e 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-agent/workspace/tez-multibranch_PR-457/src/.yetus/personality.sh
git revision	master / e841c92
Default Java	Ubuntu-21.0.9+10-Ubuntu-124.04
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-457/1/testReport/
Max. process+thread count	1348 (vs. ulimit of 5500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-457/1/console
versions	git=2.43.0 maven=3.8.7 codespell=2.4.1
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.