[SYSTEMDS-3876] Include MKL and OpenBLAS in testing docker image #2408
+381
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… matrix multiplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds installation of OpenBLAS v0.3.26 and Intel MKL 2018.0.0 to testing docker image at docker/testsysds.Dockerfile.
Added two config files, one for OpenBLAS and one for MKL:
Adjusted src/test/java/org/apache/sysds/test/component/matrix/MatrixMultiplyTest.java so that matrix multiplication can be executed with or without native instructions via LibMatrixNative.matrixMult.
Added two test classes which inherit the tests from MatrixMultiplyTests but use OpenBLAS or MKL for matrix multiplication:
Added two test classes which inherit the tests from src/test/java/org/apache/sysds/test/functions/dnn/Conv2DTest.java but use OpenBLAS or MKL for convolution:
To get the convolution to work, old Intel MKL, instead of OneAPI MKL, had to be installed. The MKL-DNN C API used in SystemDS is not included in newer versions of MKL or MKL-DNN/oneDNN.