Skip to content

[MINOR][DOCS][SQL] Fix minor gaps and problems in Thrift server docs - #57970

Open
nchammas wants to merge 3 commits into
apache:masterfrom
nchammas:sql-doc-tweak
Open

[MINOR][DOCS][SQL] Fix minor gaps and problems in Thrift server docs#57970
nchammas wants to merge 3 commits into
apache:masterfrom
nchammas:sql-doc-tweak

Conversation

@nchammas

@nchammas nchammas commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Mention sbin/stop-thriftserver.sh in the SQL docs on the Thrift server.

Flesh out the Hive config example just a tiny bit.

Also fix some minor whitespace and Markdown style issues.

Why are the changes needed?

The documentation currently mentions start-thriftserver.sh. It seems weird not to also mention the matching script to stop the service.

The existing %s is confusing by itself. Users may not immediately understand it's supposed to be a substitution marker.

Does this PR introduce any user-facing change?

Documentation only.

How was this patch tested?

Built the docs with SKIP_API=1 bundle exec jekyll serve and reviewed them locally.

Was this patch authored or co-authored using generative AI tooling?

No.

Comment thread docs/sql-distributed-sql-engine.md Outdated
Comment on lines 88 to 89
If you closed a session and do CTAS, you must set `fs.%s.impl.disable.cache` to true in `hive-site.xml`.
See more details in [[SPARK-21067]](https://issues.apache.org/jira/browse/SPARK-21067).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still true?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, but the %s marker is confusing so I've fleshed this advice out a bit.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @wangyum, do you still see this issue with the recent versions of STS?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I managed to set up a test environment with Spark 4.2.0 + Hive metastore 2.3.10 + HDFS 3.4.3 and confirmed the issue is still there, but only affects the Hive SerDe table write code path, so with default configs, Parquet/ORC tables are not affected.

@nchammas nchammas changed the title [MINOR][DOCS][SQL] Mention sbin/stop-thriftserver.sh in Thrift server docs [MINOR][DOCS][SQL] Fix minor gaps and problems in Thrift server docs Aug 12, 2026
@uros-b

uros-b commented Aug 12, 2026

Copy link
Copy Markdown
Member

Thank you @nchammas and @pan3793!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants