[SPARK-58732][ML] Avoid MLlib vector conversion in Normalizer - #57955
Closed
zhengruifeng wants to merge 4 commits into
Closed
[SPARK-58732][ML] Avoid MLlib vector conversion in Normalizer#57955zhengruifeng wants to merge 4 commits into
zhengruifeng wants to merge 4 commits into
Conversation
zhengruifeng
marked this pull request as draft
August 12, 2026 08:31
zhengruifeng
marked this pull request as ready for review
August 12, 2026 13:53
uros-b
approved these changes
Aug 12, 2026
Member
|
Thank you @zhengruifeng! |
HyukjinKwon
approved these changes
Aug 12, 2026
zhengruifeng
added a commit
that referenced
this pull request
Aug 12, 2026
### What changes were proposed in this pull request? Update ML Normalizer to calculate the norm and normalize values with ML vectors directly. The normalization implementation follows the existing MLlib Normalizer transform method, including cloning dense and sparse value arrays and reusing sparse indices. ### Why are the changes needed? ML Normalizer currently converts every input vector from ML to MLlib and converts the normalized result back to ML. Avoiding those conversions reduces allocation and transform overhead. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing NormalizerSuite covers dense, sparse, zero-vector, and parameterized normalization behavior. build/sbt 'mllib/testOnly org.apache.spark.ml.feature.NormalizerSuite' ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Codex (GPT-5) Closes #57955 from zhengruifeng/SPARK-58732-normalizer-native-vector. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com> (cherry picked from commit cddd9ae) Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update ML Normalizer to calculate the norm and normalize values with ML vectors directly. The normalization implementation follows the existing MLlib Normalizer transform method, including cloning dense and sparse value arrays and reusing sparse indices.
Why are the changes needed?
ML Normalizer currently converts every input vector from ML to MLlib and converts the normalized result back to ML. Avoiding those conversions reduces allocation and transform overhead.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
The existing NormalizerSuite covers dense, sparse, zero-vector, and parameterized normalization behavior.
build/sbt 'mllib/testOnly org.apache.spark.ml.feature.NormalizerSuite'
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-5)