[SPARK-58714][SS] Fix AdminClient leak in KafkaTokenUtil.obtainToken - #57953
Open
pan3793 wants to merge 1 commit into
Open
[SPARK-58714][SS] Fix AdminClient leak in KafkaTokenUtil.obtainToken#57953pan3793 wants to merge 1 commit into
pan3793 wants to merge 1 commit into
Conversation
Assisted-by: Claude Fable 5
Member
Author
uros-b
approved these changes
Aug 12, 2026
Member
|
Thank you @pan3793! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Wrap the token acquisition in
KafkaTokenUtil.obtainTokenintry/finallyso the createdAdminClientis always closed, viaUtils.closeQuietly.Why are the changes needed?
obtainTokencreates anAdminClientbut never closes it, on either the success or the exception path. Each token obtain (per cluster, per renewal cycle) and each failed attempt leaks the client's network thread and sockets, which accumulate in long-running drivers.Present since the feature was introduced in SPARK-25501 (Spark 3.0.0).
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests (
KafkaTokenUtilSuite).Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-fable-5)