[SPARK-58721][K8S] Add tests for ClientArguments.fromCommandLineArgs - #57944
Open
vrjdev wants to merge 1 commit into
Open
[SPARK-58721][K8S] Add tests for ClientArguments.fromCommandLineArgs#57944vrjdev wants to merge 1 commit into
vrjdev wants to merge 1 commit into
Conversation
ClientArguments.fromCommandLineArgs (in KubernetesClientApplication.scala) had zero test coverage. This adds unit tests covering all supported flags (--primary-java-resource, --primary-py-file, --primary-r-file, --main-class, --arg, --proxy-user) and its error paths (missing --main-class, an unrecognized flag, and a trailing flag with no value). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
vrjdev
force-pushed
the
k8s-clientarguments-test
branch
from
August 12, 2026 01:43
795bf81 to
0c50a71
Compare
uros-b
approved these changes
Aug 12, 2026
Member
|
Thank you @vrjdev! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds unit tests for
ClientArguments.fromCommandLineArgsinKubernetesClientApplication.scala, covering all supported command-line flags and its error paths.Why are the changes needed?
This is a small, pure function with zero direct test coverage. The sibling
Clientclass in the same file is thoroughly tested viaClientSuite.scala, butClientArguments' own parsing logic - including its error paths (missing--main-class, an unrecognized flag, a trailing flag with no value) - was untested.Does this PR introduce any user-facing change?
No.
How was this patch tested?
New unit tests in
ClientArgumentsSuite.scala, run locally viabuild/sbt -Pkubernetes 'kubernetes/testOnly *ClientArgumentsSuite'- all 11 tests pass.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Sonnet 5