[WIP][SPARK-XXXXX][SQL][TESTS] Refactor some DSv2 tests to use SessionQueryTest#56708
Open
fwc wants to merge 59 commits into
Open
[WIP][SPARK-XXXXX][SQL][TESTS] Refactor some DSv2 tests to use SessionQueryTest#56708fwc wants to merge 59 commits into
fwc wants to merge 59 commits into
Conversation
added 30 commits
June 9, 2026 12:49
…parkSession This is technically an 'api change' as it moves the thread audit stuff from `test.SharedSparkSession` to `test.SharedSparkSessionBase`. This breaks code that implements `SharedSparkSessionBase` to circumvent the thread audit stuff.
…nType and by implementing QueryTest
This reverts commit 176a528.
fwc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR builds upon #56190 and refactors the existing classic/connect-targeting DSv2 tests to use
SessionQueryTest.NOTE: this PR is stacked upon #56190 and WIP until that PR is merged and this PR is rebased. The actual changes are to the files in
sql/core/src/test/scala/org/apache/spark/sql/connector/and tosql/connect/server/src/test/scala/org/apache/spark/sql/connect/DataSourceV2DataFrameConnectSuite.scala(currently ea62c55)Why are the changes needed?
This PR reduces the amount of custom test helpers.
Does this PR introduce any user-facing change?
No
How was this patch tested?
This patch is test-only
Was this patch authored or co-authored using generative AI tooling?
No