fix Perlcritic tests in Mail::SpamAssassin::Handler code - #37
Closed
bigio wants to merge 1 commit into
Closed
Conversation
Contributor
|
I was just starting on that too. I've been going through to verify that there's no obscure bug to be introduced. There is a difference between return undef; and return; if it is called in list context. But I think I've proven that it can't be called that way in any of these cases. There are a couple more files where the Perlcritic test was silenced which should be fixed the same way instead, I'll get those too. |
Contributor
|
I've created https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8409 to work on this. Thanks for the submission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.