[fix][broker] Log replicated subscription update ack failures - #26109
Open
Denovo1998 wants to merge 3 commits into
Open
[fix][broker] Log replicated subscription update ack failures#26109Denovo1998 wants to merge 3 commits into
Denovo1998 wants to merge 3 commits into
Conversation
void-ptr974
approved these changes
Jul 1, 2026
void-ptr974
left a comment
Contributor
There was a problem hiding this comment.
LGTM. This change observes the future returned by replicated subscription update acknowledgements, so async ack failures are no longer silently dropped. On failure it logs the subscription name, target position, unwrapped exception, and topic context from the controller logger.
The tests cover both update paths now: when the subscription already exists, and when the subscription is created from the incoming replicated update before applying the ack.
…subscription_update_ack_failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a replicated subscription update marker is received, the broker acknowledges the target subscription position asynchronously. The returned future was previously ignored, so failures from the ack path could be dropped without any logging or completion observation.
This makes replicated subscription state updates harder to diagnose when the local ack fails.
Modifications
Verifying this change
Make sure that the change passes the CI checks.
gradlew :pulsar-broker:test --tests org.apache.pulsar.broker.service.persistent.ReplicatedSubscriptionsControllerTest -PtestRetryCount=0`
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes