Skip to content

Update Spark Plugin BUNDLE-LICENSE/NOTICE for 1.4.0#3909

Open
snazy wants to merge 3 commits intoapache:mainfrom
snazy:plugin-lic-not
Open

Update Spark Plugin BUNDLE-LICENSE/NOTICE for 1.4.0#3909
snazy wants to merge 3 commits intoapache:mainfrom
snazy:plugin-lic-not

Conversation

@snazy
Copy link
Member

@snazy snazy commented Feb 28, 2026

Fixes #3873

@snazy snazy requested a review from jbonofre February 28, 2026 10:33
@github-project-automation github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Feb 28, 2026
@snazy snazy added this to the 1.4.0 milestone Feb 28, 2026
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few mistakes in the PR.

In the meantime, I'm doing a full pass on the spark plugin (uber jar).


This binary artifact contains Apache Hive.

Copyright: 2008-2020 The Apache Software Foundation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: copyright and home page are not strictly required in LICENSE.


--------------------------------------------------------------------------------

This binary artifact contains fast_float.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is a duplicate from previous one.

This binary artifact contains fast_float.

Project URL: https://github.com/fastfloat/fast_float
License: MIT - https://github.com/fastfloat/fast_float/blob/35d523195bf7d57aba0e735ad6eba1e6f71ba8d6/LICENSE-MIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of the link, for BSD and MIT licenses, we have to copy the license content inline here.


--------------------------------------------------------------------------------

This binary artifact contains code from Kite, developed at Cloudera, Inc. with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's covered by the Iceberg NOTICE.

This binary artifact includes Google Protobuf with the following copyright
notice:

| Copyright 2008 Google Inc. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a BSD license. So the license content should be inline in the LICENSE, not in NOTICE.

The NOTICE should only contains NOTICE from Apache license, and only Apache license, dependencies.

https://github.com/locationtech/jts/blob/master/LICENSES.md
https://github.com/geotools/geotools/wiki/JTS-Shapefile-Contribution

| Copyright (c) 2003, Open Source Geospatial Foundation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a BSD license, so the license content should be in the LICENSE, not the NOTICE.


This binary artifact contains code from FastDoubleParser with the following license:

| # FastDoubleParser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a MIT license, so license content should be in LICENSE file, not in NOTICE.


This binary artifact contains code from fast_float with the following license:

| Third-party license for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a MIT license, so the license content should be in the LICENSE file, not the NOTICE file.


This binary artifact contains code from bigint with the following license:

| Third-party license for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a BSD license, so the license content should be in the LICENSE file, not in the NOTICE file.

@snazy
Copy link
Member Author

snazy commented Feb 28, 2026

@jbonofre I've pushed an update via the review commit.

The 3rd commit is a different approach by "just" copying the contents of the iceberg-spark-runtime.jar's LICENSE + NOTICE files. I'd expect those to be legally correct. As the iceberg-spark-runtime.jar is the only dependency that the plugin pulls in, it should be sufficient. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LICENSE + NOTICE for Spark plugin are missing dependencies

2 participants