chore: add missing licenses/workflows and standardized license headers#71
Closed
MonkeyCanCode wants to merge 4 commits intoapache:mainfrom
Closed
chore: add missing licenses/workflows and standardized license headers#71MonkeyCanCode wants to merge 4 commits intoapache:mainfrom
MonkeyCanCode wants to merge 4 commits intoapache:mainfrom
Conversation
Closed
This was referenced Nov 23, 2025
MonkeyCanCode
changed the title
snazy
reviewed
Nov 24, 2025
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
Thanks for the PR @MonkeyCanCode !
It's a bit hard to review across all the tools. Would you mind splitting this PR by tool and concern?
| - name: Build & Check | ||
| run: | | ||
| cd iceberg-catalog-migrator | ||
| ./gradlew --rerun-tasks assemble ${{ env.ADDITIONAL_GRADLE_OPTS }} check publishToMavenLocal |
Member
There was a problem hiding this comment.
This is intentional and part of the checks. Please do not remove.
Member
|
Imho, LICENSE/NOTICE/DISCLAIMER are not correct in MCP server. I will create another PR to fix that. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixed couple issues:
publishToMavenLocalfrom workflows as we are not creating local maven repo for these tools projects.gitignoreto exclude gradle wrapper checksum filepolaris-synchronizer/gradlew