Skip to content

PHOENIX-7266 Fix SSLConfigDir in ITs#150

Open
Aarchy wants to merge 1 commit intoapache:masterfrom
Aarchy:classpath
Open

PHOENIX-7266 Fix SSLConfigDir in ITs#150
Aarchy wants to merge 1 commit intoapache:masterfrom
Aarchy:classpath

Conversation

@Aarchy
Copy link
Contributor

@Aarchy Aarchy commented Mar 8, 2024

No description provided.

protected static final String TARGET_DIR_NAME = System.getProperty("target.dir", "target");
protected static final File TARGET_DIR =
new File(System.getProperty("user.dir"), TARGET_DIR_NAME);
protected static final String TEST_CLASSES_DIR_NAME =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few lines of comments on what is happening here would be useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this, as these are just directory names, there isn't really a complex logic behind them. There are very similar definitions in the preceding lines without comments as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants