[flink] Report which required argument is missing in action factories - #9059
Open
thswlsqls wants to merge 1 commit into
Open
[flink] Report which required argument is missing in action factories#9059thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
Four required action arguments were read with params.get(...) and dereferenced immediately, so omitting one failed with a bare NullPointerException (merge_actions) or NumberFormatException: null (timestamp, watermark) that never named the missing argument. Read them with params.getRequired(...), like every sibling argument in the same methods, so the failure reports the argument name. Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #9058
merge_intothrows a bareNullPointerException,create_tag_from_timestampandcreate_tag_from_watermarkthrowNumberFormatException: null.merge_actions,timestamp,tag,watermark) are read withparams.get(...)and dereferenced at once.params.getRequired(...), which reportsArgument '<name>' is required.;DropPartitionActionFactoryenforces the same contract.migrate_*factories.Tests
MergeIntoActionFactoryTest,CreateTagFromTimestampActionFactoryTestandCreateTagFromWatermarkActionFactoryTest(7 tests). The four missing-argument tests fail without this change.mvn -pl paimon-flink/paimon-flink-common -Pflink1 -DfailIfNoTests=false clean install— BUILD SUCCESS, 2258 tests, 0 failures, 8 skipped.