[core] Abort single file writers on unchecked close failures - #9016
Merged
JingsongLi merged 2 commits intoAug 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #9007.
close()inSingleFileWriterandFormatTableSingleFileWriterrouted onlyIOExceptiontoabort(), so an unchecked failure skipped cleanup entirely. Thefinallystill setsclosed = true, so nothing cleans up later either: the output stream stays open and the partially written file is orphaned.writeImpl(),writeRow()andwriteBundle()have caughtThrowableand calledabort()since 2024, onlyclose()was left narrower.This is on the default path.
async-file-writedefaults totrue, andAsyncPositionOutputStreamthrows a bareRuntimeExceptionfromflush()andclose()when the writing thread is interrupted, so cancelling a Flink job can orphan a data file.abort()is wrapped becauseFileIO.deleteQuietlyonly swallowsIOException, so an unchecked cleanup failure would otherwise replace the real error. The rolling writers above still catch onlyIOExceptionand are left for a separate change.Tests
Six tests in
SingleFileWriterTestandFormatTableSingleFileWriterTest: unchecked failure from the format writer'sclose(), unchecked failure from the stream'sflush()(asserting viaTraceableFileIOthat the stream is released),IOExceptionstill reaching the caller unwrapped, and a failingabort()not replacing the original exception. All fail against the unpatched code.