[python] refactor file_io to support polymorphism #7040
+1,349
−565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
January 14, 2026 15:22
XiaoHongbo-Hope
changed the title
XiaoHongbo-Hope
changed the title
XiaoHongbo-Hope
changed the title
XiaoHongbo-Hope
changed the title
XiaoHongbo-Hope
changed the title
XiaoHongbo-Hope
changed the title
discivigour
reviewed
Jan 15, 2026
| self.filesystem = self._initialize_s3_fs() | ||
| elif scheme in {"hdfs", "viewfs"}: | ||
| self.filesystem = self._initialize_hdfs_fs(scheme, netloc) | ||
| elif scheme in {"file"}: |
Contributor
There was a problem hiding this comment.
Maybe local file system is not needed here.
Contributor
Author
There was a problem hiding this comment.
Maybe local file system is not needed here.
removed
discivigour
reviewed
Jan 15, 2026
|
|
||
| RENAME_LOCK = threading.Lock() | ||
|
|
||
| INSTANCE = None |
Contributor
There was a problem hiding this comment.
Do we need INSTANCE variable?
Contributor
Author
There was a problem hiding this comment.
Do we need INSTANCE variable?
removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
refactor file_io to support polymorphism instead of involve all the logic into one class.
Before:
FileIoRestTokenFileIoAfter:
FileIoLocalFileIoPyArrowFileIORESTTokenFileIOTests
API and Format
Documentation