Conversation
Encode ordered image bytes or Pillow images into an MP4, then reuse the existing video-frame descriptor write path. Require explicit encoding parameters and validate frame counts and dimensions before committing data. Co-Authored-By: Codex <noreply@anthropic.com> AI-Model: gpt-6 Co-Authored-By: Codex <noreply@ai-tool.com> AI-Contributed/Feature: 179/179 AI-Contributed/UT: 191/191
Akash3121
approved these changes
Sep 25, 2026
Akash3121
left a comment
Contributor
There was a problem hiding this comment.
LGTM
The image-to-video encoder validates inputs, streams image iteration into a temporary MP4, cleans partial output on encoding failures, verifies image/row cardinality before writing, and safely reuses the existing descriptor-backed video path. The optional dependency markers preserve Python 3.6/3.7 compatibility, while CI exercises the new extra on Python 3.10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Allow PyPaimon users to append ordered image bytes or Pillow images to a video-frame field without first creating an MP4 themselves.
MultimodalTable.add_images_as_videoencodes the images with explicit FPS, codec, pixel format, GOP size, and codec options, then reuses the existingadd_videodescriptor and blob write path.The encoder validates non-empty input, equal image dimensions, and a one-to-one match between images and table rows. Encoding completes in a temporary file before a Paimon commit, and partial files are removed on failure. The optional
pypaimon[video]extra supplies PyAV and Pillow on Python 3.10 or newer.Tests