HDDS-13590. Refactor HealthyPipelineSafeModeRule to not use PipelineReportFromDatanode #9651
+108
−132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactored HealthyPipelineSafeModeRule to make it simpler and more reliable.
Earlier, it depended on events and internal state to track pipelines. Now, it directly checks the current state from the PipelineManager whenever validation is needed.
HealthyPipelineSafeModeRule.java
Pipeline has exactly 3 nodes
All nodes are in healthy state (NodeStatus.inServiceHealthy())
All nodes are registered with the node manager
SafeModeMetrics.java
Replaced incCurrentHealthyPipelinesCount() with setNumCurrentHealthyPipelines(long)
Test Updates
What is the link to the Apache JIRA
HDDS-13590
How was this patch tested?
Tested using existing testcases written for safemode validation rules and Safemode Manager.
Validated using forked CI.