HDDS-16247. Separate StorageContainerLocationProtocol RPC identity from its internal Java interface - #11098
Open
echonesis wants to merge 4 commits into
Open
HDDS-16247. Separate StorageContainerLocationProtocol RPC identity from its internal Java interface#11098echonesis wants to merge 4 commits into
echonesis wants to merge 4 commits into
Conversation
…om its internal Java interface
chihsuan
approved these changes
Sep 6, 2026
chihsuan
left a comment
Contributor
There was a problem hiding this comment.
Thanks @echonesis +1 LGTM.
# Conflicts: # hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/spi/impl/TestStorageContainerServiceProviderImpl.java
Preserve the shared Kerberos test getters and StorageContainerLocationInternalInterface in TestSecureOzoneCluster. Validated with JDK 21: clean reactor build, TestStorageContainerLocationProtocolPB, secure SCM/OM startup and access control, TestFailoverWithSCMHA, and checkstyle.
Preserve dynamic SCM proxy reconfiguration while using StorageContainerLocationInternalInterface for container clients and test mocks. Validated with JDK 21: clean integration-test reactor build, 17 unit tests, 13 integration tests covering secure SCM/OM access control, SCM HA failover and OM SCM nodes reconfiguration, and CI checkstyle (0 violations). Generated-by: Codex (GPT-6)
rich7420
approved these changes
Oct 5, 2026
rich7420
left a comment
Contributor
There was a problem hiding this comment.
Thanks @echonesis for the patch. Protocol metadata, secure SCM/OM access control, and SCM HA tests passed locally (6 tests, 0 failures or errors). Checkstyle passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
StorageContainerLocationProtocolcurrently serves two different purposes:The actual Hadoop RPC protocol is
StorageContainerLocationProtocolPB, which extends the generated Protobuf blocking interface and provides the RPC protocol name, version, and Kerberos metadata. Keeping the internal Java methods inStorageContainerLocationProtocolincorrectly makes changes to an internal interface appear to be changes to the RPC protocol.This pull request separates these responsibilities:
StorageContainerLocationProtocolas an empty final class so that its historical FQCN remains available as the RPC identity.StorageContainerLocationInternalInterface.StorageContainerLocationProtocolPBcontinues to provide the historical protocol name, version, and Kerberos metadata.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16247
How was this patch tested?
Local Tests
GitHub Actions CI: https://github.com/echonesis/ozone/actions/runs/32688066691
Generated-by: Codex (GPT-5)