refactor(services)!: use typed durations for moka configs - #8033
Open
subotac wants to merge 1 commit into
Open
Conversation
Member
|
Hold on this PR until our next patch version released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8025
Rationale for this change
Moka and MiniMoka are the remaining services that keep cache durations as strings and parse them again during backend construction. Their builders also format
Duration::as_secs(), which truncates subsecond valuesbefore parsing.
What changes are included in this PR?
SignedDuration.signed_duration_to_durationDurationvalues as lossless overridesAre there any user-facing changges?
Yes.
MokaConfigandMiniMokaConfignow exposeOption<SignedDuration>fortime_to_liveandtime_to_idleinstead ofOption<String>. String-based configuration continues to accept duration values such as1500ms