feat(services/azdls): support custom credential providers - #8030
Open
zakariya-s wants to merge 2 commits into
Open
feat(services/azdls): support custom credential providers#8030zakariya-s wants to merge 2 commits into
zakariya-s wants to merge 2 commits into
Conversation
dosubot
Bot
added
size:M
Author
|
Hi @Xuanwo! Could I get a review for this please? It's hopefully the only prerequisite for Azure refreshing vended credential support in iceberg-rust. Currently we can only support S3 and GCS through OpenDAL |
6 tasks
Author
|
flaky existing test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8029.
Rationale for this change
Azdls currently builds its credential chain from configured static credentials and reqsign’s default Azure providers. Applications that load credentials dynamically cannot inject a credential provider into a long-lived Azdls operator.
What changes are included in this PR?
Add
credential_providerandcredential_provider_chaintoAzdlsBuilder.For proper SAS cred rotation (to support refreshing creds, for example in iceberg-rust which was the motivation for this PR: apache/iceberg-rust#2932), this relies on apache/opendal-reqsign#803,
but there has not yet been a new release of reqsign including the change. This PR should still be independent of a new release of reqsign.For expiry-aware SAS rotation, this complements apache/opendal-reqsign#803, which is available in
reqsign-azure-storage3.2.0. The provider-injection API itself remains compatible with OpenDAL’s existing minimum reqsign dependency.Are there any user-facing changes?
Yes, Azdls users can now supply custom reqsign credential providers and provider chains.
No breaking changes.
AI Usage Statement