feat(services/s3): add R2 and MinIO presets - #8013
Draft
Xuanwo wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #8003.
Rationale for this change
Cloudflare R2 and MinIO expose S3-compatible APIs, but each provider has a smaller configuration contract and distinct endpoint, region, and credential rules. Requiring users to configure them through the generic
s3service adds avoidable setup and exposes options that do not belong to those providers.Dedicated presets provide provider-owned defaults and validation while continuing to share the S3 runtime. The generic
s3service remains the escape hatch for the complete S3 configuration surface.What changes are included in this PR?
R2/R2ConfigandMinio/MinioConfigwith dedicatedr2://andminio://schemes.services-r2andservices-miniofacade features. Enablingservices-s3does not enable either preset.compatible_services.mdas the guide for providers that still use the generics3service.Are there any user-facing changes?
Yes. Rust users can enable only the provider they need and configure its smaller contract. R2 can derive its endpoint from
account_id; MinIO requires its deployment endpoint and defaults the signing region toauto. Existings3configurations remain unchanged.How was this change tested?
services-s3,services-r2, andservices-minio.git diff --checkpassed.AI Usage Statement
I used OpenAI Codex with GPT-5 to implement and validate this change.