sched/signals: improvements for when all signals are disabled#17991
Merged
xiaoxiang781216 merged 13 commits intoapache:masterfrom Feb 26, 2026
Merged
sched/signals: improvements for when all signals are disabled#17991xiaoxiang781216 merged 13 commits intoapache:masterfrom
xiaoxiang781216 merged 13 commits intoapache:masterfrom
Conversation
wangchdo
requested review from
GUIDINGLI,
gustavonihei,
jerpelea,
raiden00pl,
simbit18 and
xiaoxiang781216
as code owners
github-actions
bot
added
Area: Drivers
wangchdo
force-pushed
the
fix_disable_all_signals_issue
branch
2 times, most recently
from
c53b84a to
6b46448
Compare
xiaoxiang781216
previously approved these changes
Jan 18, 2026
wangchdo
force-pushed
the
fix_disable_all_signals_issue
branch
from
6b46448 to
a1c1f12
Compare
wangchdo
requested review from
acassis,
antmerlino,
michallenc,
pkarashchenko and
yamt
as code owners
github-actions
bot
added
Area: Networking
wangchdo
force-pushed
the
fix_disable_all_signals_issue
branch
2 times, most recently
from
fb52bef to
286d12b
Compare
github-actions
bot
removed
Area: Sensors
When all signals are disabled, remove the altmdm_timer-related implementation and API definitions. Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>
When all signals are disabled, nxsig_notification is not available and should not be invoked. Remove the call to avoid build and runtime issues in no-signal configurations. Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>
DEV_GPIO_NSIGNALS relies on signal support. Add an explicit Kconfig dependency on SIGNALS to prevent invalid no-signal configurations. Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>
When all signals are disabled, nxsig_notification is not available and should not be invoked. Remove the call to avoid build and runtime issues in no-signal configurations. Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>
Move the implementation of nxsig_clockwait() into a separate file to decouple it from nxsig_timedwait(). Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>
Update nxsig_clockwait() to handle the case where all signals functions are disabled. Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>
When all signals are disabled, nxsig_notification is not available and should not be invoked. Remove the call to avoid build and runtime issues in no-signal configurations. Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>
…abled When all signals are disabled, nxsig_notification is not available and should not be invoked. Remove the call to avoid build and runtime issues in no-signal configurations. Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>
…bled When all signals are disabled, nxsig_notification is not available and should not be invoked. Remove the call to avoid build and runtime issues in no-signal configurations. Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>
When all signals are disabled, nxsig_notification is not available and should not be invoked. Remove the call to avoid build and runtime issues in no-signal configurations. Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>
wangchdo
force-pushed
the
fix_disable_all_signals_issue
branch
from
d93decb to
94c3ea4
Compare
github-actions
bot
added
Size: L
when all signals are disabled, aio should not be enabled Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>
disable fs automounter when no signals, since fs automounter depends on signals Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>
pthread_kill depends on signasl, so when all signals are disabled disable pthread_kill too Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>
wangchdo
force-pushed
the
fix_disable_all_signals_issue
branch
from
94c3ea4 to
b8b00ec
Compare
xiaoxiang781216
approved these changes
Feb 26, 2026
Contributor
Author
jerpelea
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
THis PR includes below three updates:
sleep()andusleep()to usenxsched_nanosleep()when all signals are disabled, so when all signals are disabled, sleep function can still be available and ostest can passpthread_kill()andpthread_sigmask()implementations when all signals are disabled, since these two functions rely on signalsImpact
Improve the implementation when all signals are disabled, only impact the functions when all signals are disabled.
Testing
ostest for when all signals are disabled depends on apache/nuttx-apps#3333
ostest passed on rv-virt:smp64