net/usrsock: Fix EPIPE loop by clearing POLLIN on remote close #17877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear USRSOCK_EVENT_RECVFROM_AVAIL flag when remote closes connection during accept to prevent repeated POLLIN events and EPIPE loop. Signed-off-by: daichuan <[email protected]>
13627105546
requested review from
jerpelea and
xiaoxiang781216
as code owners
github-actions
bot
added
Area: Networking
xiaoxiang781216
approved these changes
Jan 14, 2026
jerpelea
changed the title
Contributor
Author
|
This commit must be applied after apache/nuttx-apps#3340. |
Contributor
|
@13627105546 please rebase your patch to the last master which fix the ci break. |
13627105546
force-pushed
the
topic/usrsock-poll-fix
branch
from
c0f8f68 to
9b52cc5
Compare
xiaoxiang781216
approved these changes
Jan 20, 2026
jerpelea
approved these changes
Jan 20, 2026
In usrsock_pollsetup, only set POLLIN if USRSOCK_EVENT_RECVFROM_AVAIL is set when remote is closed, avoiding invalid POLLIN events. Signed-off-by: daichuan <[email protected]>
13627105546
force-pushed
the
topic/usrsock-poll-fix
branch
from
9b52cc5 to
5a8fc38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
This PR addresses an issue where
usrsockrepeatedly setsPOLLINevents when the network interface is down and a client attempts to connect, leading to an infinite loop or abnormalEPIPEsetting.The changes involve:
USRSOCK_EVENT_RECVFROM_AVAILflag when a remote connection is closed duringaccept.USRSOCK_EVENT_RECVFROM_AVAILflag before settingPOLLINin bothpoll_eventandusrsock_pollsetup.By ensuring
POLLINis only set when data is actually available (indicated by the flag), we prevent the repetitivePOLLINtriggering that causes theEPIPEloop.Impact
usrsockwhen handling connection attempts on a down interface.Testing
POLLINis no longer repeatedly set when the remote closes the connection during an accept sequence on a down interface.tools/checkpatch.sh.