Revert gradle downloader TLS handshake workaround again.

[mbien]

workaround is no longer needed. (unclear what fixed it, likely some of the routine dependency updates)

partially reverts c0f09c9

fixes #6680

[mbien]

would be interesting to find out what fixed this issue, but bisecting would be too time consuming for me right now.

[matthiasblaesing]

would be interesting to find out what fixed this issue, but bisecting would be too time consuming for me right now.

The message from c0f09c9 says, that the problem occurs when downloading. Wouldn't "they fixed the server" be the most sensible explanation? If so, you would not find the reason by bisecting.

[matthiasblaesing]

Not a formal review, but +1 for removing ugly workaround.

[mbien]

Wouldn't "they fixed the server" be the most sensible explanation?

yeah that was also my original hypothesis #6673 (comment) (although the server is still configured to not allow tls 1.3 so that didn't change at least). But there were more weird things going on, e.g other tests were able to download gradle.

[mbien]

fwiw: still reproducible today when checking out a hash shortly after the workaround was added via #6673. The 23-rc1 tag is working while 22-rc1 fails.

Not going to narrow it down further given how time consuming the rebuild/kill daemons/clear gradle cache/run test cycle is.

Most plausible cause for the resolution would be one of the routine dep updates #7583, #7690.

Going to merge this PR. Thanks for taking a look.