[MARTIFACT-58] add warn log for each dependency stemming from a local repository - #227
Open
sebtiem wants to merge 1 commit into
Open
[MARTIFACT-58] add warn log for each dependency stemming from a local repository#227sebtiem wants to merge 1 commit into
sebtiem wants to merge 1 commit into
Conversation
… repository during buildinfo mojo
cstamas
approved these changes
Aug 7, 2026
sparsick
approved these changes
Aug 7, 2026
Bukama
approved these changes
Aug 7, 2026
hboutemy
requested changes
Aug 7, 2026
hboutemy
left a comment
hboutemy
left a comment
Member
There was a problem hiding this comment.
really nice addition to give a chance to discover local rebuilds
just trying to get message that is easier to understand "why" and act accordingly
|
|
||
| if (resultRepo instanceof LocalRepository) { | ||
| log.warn(String.format( | ||
| "The artifact %s:%s:%s is stemming from your local Maven repository. " |
Member
There was a problem hiding this comment.
"from your local Maven repository." => "from a local install to your local Maven repository."
| if (resultRepo instanceof LocalRepository) { | ||
| log.warn(String.format( | ||
| "The artifact %s:%s:%s is stemming from your local Maven repository. " | ||
| + "Please ensure that this is intended. " |
Member
There was a problem hiding this comment.
- " and that your local installed artifact matches public reference from remote."
this helps understand the risk of locally installed releases vs reference published to remote
| log.warn(String.format( | ||
| "The artifact %s:%s:%s is stemming from your local Maven repository. " | ||
| + "Please ensure that this is intended. " | ||
| + "If not, consider removing this artifact and rebuilding.", |
Member
There was a problem hiding this comment.
adding the path to the local repository directory of the artifact version would help delete
Member
|
notice: I don't think the reference to https://issues.apache.org/jira/browse/MARTIFACT-58 is really useful: this PR is much more focused and interesting |
olamy
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.