chore(pre-commit): add default install config for pre-commit#862
chore(pre-commit): add default install config for pre-commit#862yangxk1 merged 2 commits intoapache:mainfrom
Conversation
…te conventional-pre-commit to latest version
38d68af to
875e217
Compare
|
@Sober7135 When you have time, could you please help review this PR? Thank you. |
|
Sorry, I’m not very familiar with |
Ok, thank you. |
There was a problem hiding this comment.
Pull request overview
This PR simplifies the pre-commit installation process by adding a default_install_hook_types configuration to .pre-commit-config.yaml, eliminating the need to run separate pre-commit install --hook-type commit-msg commands. The PR also upgrades the conventional-pre-commit tool from v3.0.0 to v4.3.0 and modifies its configuration arguments.
Changes:
- Added
default_install_hook_typesto automatically install both pre-commit and commit-msg hooks with a singlepre-commit installcommand - Upgraded conventional-pre-commit from v3.0.0 to v4.3.0
- Simplified conventional-pre-commit configuration by removing explicit type definitions and replacing with --verbose flag
Comments suppressed due to low confidence (1)
.pre-commit-config.yaml:66
- There appears to be trailing whitespace on line 66 (after the closing bracket). This should be removed for consistency with the rest of the file.
args: [--verbose]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
keep the explicit types configuration Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jason <libevent@yeah.net>
Reason for this PR
The conventional-pre-commit could be installed by the following script:
A better way is to set a default configuration in
.pre-commit-config.yamland installed bypre-commit installWhat changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?