Repository navigation
Conversation
anoopj
force-pushed
the
v4-tight-stats-impl
branch
from
October 22, 2026 01:08
5486e0b to
f24db6d
Compare
anoopj
changed the title
nastra
reviewed
Oct 22, 2026
nastra
reviewed
Oct 22, 2026
| /** | ||
| * Returns whether the file's stats are tight, or null if unknown. | ||
| */ | ||
| default Boolean tightStats() { |
Contributor
There was a problem hiding this comment.
what's the reason for adding v4-specific things to v1-v3 APIs?
Member
Author
There was a problem hiding this comment.
ContentFile is still the engine-facing API in v4 as well, since TrackedFile family is internal. So don't we need a way to expose this during reads and writes?
Implements the file-level tight_stats flag on v4 tracked files and the related content stats changes. Spec PR: apache#18585
anoopj
force-pushed
the
v4-tight-stats-impl
branch
from
October 22, 2026 17:16
baa75de to
b83e1df
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the file-level tight_stats flag on v4 tracked files and the related content stats changes.
Spec PR: #18585