[MINOR] fix(test): cover SparkContext shutdown path in HoodieMetadataTableValidator

[lokeshj1703]

What is the purpose of this PR?

Add two tests that verify the catch (SparkException) behaviour introduced in #18371
(ExceptionUtil.validateErrorMsg guard in doMetadataTableValidation):

1. testDoMetadataTableValidationThrowsHoodieExceptionOnSparkContextShutdown — a SparkException containing "cancelled because SparkContext was shut down" must be wrapped in HoodieException, not HoodieValidationException.

2. testDoMetadataTableValidationThrowsHoodieValidationExceptionOnUnexpectedSparkFailure — any other SparkException must still produce HoodieValidationException("Unexpected spark failure"), covering the false-branch of the ExceptionUtil.validateErrorMsg condition for Sonar branch coverage.

Key implementation details

• Static nested classes instead of anonymous classes: an anonymous subclass of HoodieMetadataTableValidator would implicitly capture TestHoodieMetadataTableValidator.this, which is not Serializable. That causes Spark's parallelize().map() to throw "Task not serializable", which the outer catch converts to HoodieValidationException rather than the intended HoodieException.
• validateLatestFileSlices / validateAllFileGroups left false: enabling them invokes validateFilesInPartition inside the Spark map job, which can throw HoodieValidationException before validateRecordIndex is ever reached, masking the exception the test intends to assert.

Does this PR introduce any user-facing changes?

No — test-only change.

[hudi-agent]

⚠️ 🤖 This review was generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.

Thanks for the contribution! This PR adds two tests covering the catch (SparkException) branches in HoodieMetadataTableValidator.doMetadataTableValidation — one asserting a SparkContext-shutdown message is wrapped in HoodieException, and one asserting other Spark failures still yield HoodieValidationException("Unexpected spark failure"). I traced both tests against the production code: the exception propagation, the assertThrows/assertFalse distinction (relying on HoodieValidationException extends HoodieException), the no-op validateFilesInPartition path (all sub-flags default false), and the static-nested-class serialization reasoning all check out. No correctness issues found. A few style/readability suggestions in the inline comments. Please take a look, and this should be ready for a Hudi committer or PMC member to take it from here. One small readability nit on sneakyThrow; otherwise the tests are well-structured and the explanatory comments are genuinely useful.

cc @yihua

[hudi-agent]

🤖 nit: could you add a brief Javadoc on sneakyThrow explaining the constraint that drives it? Something like /** SparkException is checked; overrides cannot widen the throws clause, so this unchecked-cast rethrow is needed. */ would save the next reader a "why not just throw it?" moment.

_{⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.}

[voonhous]

+1

[hudi-bot]

CI report:

• b0e4be9 Azure: SUCCESS

Bot commands

@hudi-bot supports the following commands:

• @hudi-bot run azure re-run the last Azure build

[voonhous]

@lokeshj1703 Can you modify the description such that it passes the PR Compliance / validate-pr validation? Thanks.

Overall, LGTM, address the comments above and it's good to go.

[hudi-agent]

⚠️ 🤖 This review was generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.

Thanks for the contribution! This PR adds two tests covering the catch (SparkException) branches in doMetadataTableValidation — distinguishing the SparkContext-shutdown case (wrapped as HoodieException) from the generic case (HoodieValidationException). I traced the injected SparkException through the actual control flow and confirmed both tests reach the intended branch: the overridden validateRecordIndex propagates past the inner HoodieValidationException-only catch to the outer SparkException handler, and all validateFilesInPartition flags default to false so nothing throws earlier. No issues flagged from this automated pass — a Hudi committer or PMC member can take it from here for a final review.

cc @yihua