Repository navigation
test(core): add hfile compression codec coverage - #622
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
+ Coverage 79.28% 79.43% +0.14%
==========================================
Files 126 126
Lines 12311 12311
==========================================
+ Hits 9761 9779 +18
+ Misses 2550 2532 -18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
yihua
approved these changes
Sep 3, 2026
yihua
left a comment
Contributor
There was a problem hiding this comment.
LGTM. @slfan1989 Thanks for the contribution!
16 tasks done
Contributor
Author
|
@yihua Thanks so much for reviewing my code! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add dedicated unit test coverage for the HFile compression codec implementation in
crates/core/src/hfile/compression.rs.The new tests cover:
CompressionCodecvariantsHFileError::UnsupportedCompressionNonecodecThis is a test-only change and does not modify production behavior.
Closes #621.
How are the changes test-covered
Added six unit tests covering codec ID parsing, successful decompression paths, and error handling paths in the HFile compression module.