Skip to content

Keep Hop Web Help button icon aligned with OK/Cancel - #8181

Merged
hansva merged 1 commit into
apache:mainfrom
leehaut:hotfix/lance-common-17
Aug 31, 2026
Merged

Keep Hop Web Help button icon aligned with OK/Cancel#8181
hansva merged 1 commit into
apache:mainfrom
leehaut:hotfix/lance-common-17

Conversation

@leehaut

@leehaut leehaut commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • In Hop Web (RAP), dialog Help buttons were taller than the text-only OK/Cancel row because RAP sizes PUSH buttons to the zoomed help bitmap plus theme padding. Native Hop GUI already fits the 16px icon in platform chrome.
  • Keep the question-mark icon on Web: request a pre-zoom size so the bitmap lands at 16px, apply a compact helpButton RAP variant (padding: 4px 12px), and lock FormData.height to the text-only preferred height.
  • Desktop Help buttons are unchanged. NotePadDialog now uses the same HelpUtils.applyHelpButtonImage helper.

Signed-off-by: lance <leehaut@gmail.com>
@hansva
hansva merged commit 3a11fb1 into apache:main Aug 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants