HIVE-29442: Avoid redundancy in FilterStatsRule#evaluateComparator#6300
Open
thomasrebele wants to merge 1 commit intoapache:masterfrom
Open
HIVE-29442: Avoid redundancy in FilterStatsRule#evaluateComparator#6300thomasrebele wants to merge 1 commit intoapache:masterfrom
thomasrebele wants to merge 1 commit intoapache:masterfrom
Conversation
thomasrebele
force-pushed
the
tr/HIVE-29442
branch
from
efea421 to
969dd2a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HIVE-29442
What changes were proposed in this pull request?
The bottom part of FilterStatsRule#evaluateComparator repeats a very similar code block 6 times. Implementing HIVE-29364 will likely make the repeated code block even bigger. I suggest to combine those code blocks into a single one, while still keeping the same behavior.
Why are the changes needed?
Preparation of HIVE-29364
Does this PR introduce any user-facing change?
No
How was this patch tested?
I've disabled the histogram statistics in stats_histogram.q, and regenerated the q.out file. It is the same as without the patch.