Skip to content

HIVE-29441: Avoid resolving dependency org.glassfish:javax.el#6297

Open
thomasrebele wants to merge 1 commit intoapache:masterfrom
thomasrebele:tr/HIVE-29441
Open

HIVE-29441: Avoid resolving dependency org.glassfish:javax.el#6297
thomasrebele wants to merge 1 commit intoapache:masterfrom
thomasrebele:tr/HIVE-29441

Conversation

@thomasrebele
Copy link
Contributor

... by excluding org.glassfish.web:javax.servlet.jsp from hbase-testing-util (HIVE-29441)

What changes were proposed in this pull request?

Similar to HIVE-24809, exclude the dependency org.glassfish.web:javax.servlet.jsp from hbase-testing-util.

Why are the changes needed?

Without the patch, building fails on my machine with an exception Caused by: The following artifacts could not be resolved: org.glassfish:javax.el:pom:3.0.1-b06-SNAPSHOT (absent): Could not transfer artifact org.glassfish:javax.el:pom:3.0.1-b06-SNAPSHOT from/to jvnet-nexus-snapshots (https://maven.java.net/content/repositories/snapshots): status code: 402, reason phrase: Payment Required (402)

Does this PR introduce any user-facing change?

No

How was this patch tested?

Building Hive locally with mvn clean install -DskipTests -Pitests,dist -Denforcer.skip=true -T1C

Copy link
Member

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This annoying dependency keeps creeping in our build and remains unnoticed till the build breaks. Can we add an enforcer rule so that it does not come back ever again?

Comment on lines 200 to 205
<exclusions>
<exclusion>
<groupId>org.glassfish.web</groupId>
<artifactId>javax.servlet.jsp</artifactId>
</exclusion>
</exclusions>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we refactor the exclusion in the dependency management section instead of putting it everywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that it works, so I've updated the PR. Could you have another look, please?

Exclude org.glassfish.web:javax.servlet.jsp from hbase-testing-util
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants