HIVE-29260: Add smoke tests for Docker images#6238
Conversation
okumin
force-pushed
the
HIVE-29260-docker-smoke-test
branch
from
ab059c4 to
21df1d3
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
tests unstable
labels
okumin
force-pushed
the
HIVE-29260-docker-smoke-test
branch
from
21df1d3 to
f957972
Compare
okumin
force-pushed
the
HIVE-29260-docker-smoke-test
branch
from
f957972 to
9705373
Compare
asf-ci-hive
added
tests passed
tests pending
tests unstable
and removed
tests pending
tests passed
tests unstable
labels
|
|
hi @okumin this is awesome, but why we add k8s only for tests, why not add it for local testing? could we move the k8s setup to packaging next to docker and reuse it for tests? |
|
@deniskuzZ |
| mountPath: /tmp/ext-jars | ||
| containers: | ||
| - name: hive | ||
| image: hive:test |
There was a problem hiding this comment.
Is this a locally built test image that we use only for testing and don’t push to Docker Hub?
Should we instead build and publish nightly images here and reference them via a corresponding image tag?
There was a problem hiding this comment.
This patch builds an image locally, runs integration tests, and then publishes it to Docker Hub. If ASF allows a nightly image to be published, it could be a better option. I thought it was in a gray zone. Apache Solr has a nightly repo, and we might follow their choice
https://hub.docker.com/r/apache/solr-nightly/tags
There was a problem hiding this comment.
it builds and publishes hive:test image? i think would be better to have hive-nightly similar to solr
There was a problem hiding this comment.
It does not push hive:test because of push: false. I'm willing to start a thread to discuss if we should publish it or how we can legally push it in public 👍
|
|
Merged. @deniskuzZ Thanks for your review. |
3 participants
What changes were proposed in this pull request?
Run some integration tests against Docker images. Key points:
https://issues.apache.org/jira/browse/HIVE-29260
Why are the changes needed?
We don't run any testing on Docker images. The new test cases can relieve a release manager a bit more.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Another thought
I wonder whether we should run the test cases for every PR or for every update to the master branch. Otherwise, we run the job once a quarter, which may not allow us to detect an ongoing issue in a timely manner. The drawback is CI cost(not sure how much our budget is). Or may we merge build.yml and docker-GA-images.yml?