Skip to content

fix(hbase): handle missing CUSTOM_TIERING_TIME_RANGE in getCompactBoundariesForMajor #8573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shoemoney wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −31
Open

fix(hbase): handle missing CUSTOM_TIERING_TIME_RANGE in getCompactBoundariesForMajor #8573

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e606b18
fix(hbase): handle missing CUSTOM_TIERING_TIME_RANGE in getCompactBou…
shoemoney Aug 26, 2026
7637d74
fix(hbase): simplify getCompactBoundariesForMajor to always offer the…
shoemoney Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 6 additions & 31 deletions ...va/org/apache/hadoop/hbase/regionserver/compactions/CustomDateTieredCompactionPolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
import org.apache.commons.lang3.mutable.MutableLong;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hbase.HDFSBlocksDistribution;
import org.apache.hadoop.hbase.regionserver.HStoreFile;
Expand Down Expand Up @@ -68,38 +67,14 @@ public CustomDateTieredCompactionPolicy(Configuration conf,
@Override
protected List<Long> getCompactBoundariesForMajor(Collection<HStoreFile> filesToCompact,
long now) {
MutableLong min = new MutableLong(Long.MAX_VALUE);
MutableLong max = new MutableLong(0);
filesToCompact.forEach(f -> {
byte[] timeRangeBytes = f.getMetadataValue(CUSTOM_TIERING_TIME_RANGE);
long minCurrent = Long.MAX_VALUE;
long maxCurrent = 0;
if (timeRangeBytes != null) {
try {
TimeRangeTracker timeRangeTracker = TimeRangeTracker.parseFrom(timeRangeBytes);
timeRangeTracker.getMin();
minCurrent = timeRangeTracker.getMin();
maxCurrent = timeRangeTracker.getMax();
} catch (IOException e) {
LOG.warn("Got TIERING_CELL_TIME_RANGE info from file, but failed to parse it:", e);
}
}
if (minCurrent < min.getValue()) {
min.setValue(minCurrent);
}
if (maxCurrent > max.getValue()) {
max.setValue(maxCurrent);
}
});

// CustomTieringMultiFileWriter#append buckets each cell into its tier by comparing against
// these boundaries directly, and only commits a file for a tier that actually received data.
// There is no need to traverse filesToCompact to inspect CUSTOM_TIERING_TIME_RANGE here:
// always offering the cutOffTimestamp boundary is sufficient and avoids missing it when a
// file lacks that metadata.
List<Long> boundaries = new ArrayList<>();
boundaries.add(Long.MIN_VALUE);
if (min.getValue() < cutOffTimestamp) {
boundaries.add(min.getValue());
if (max.getValue() > cutOffTimestamp) {
boundaries.add(cutOffTimestamp);
}
}
boundaries.add(cutOffTimestamp);
return boundaries;
}

Expand Down
Loading