HBASE-30343 Per-table avgStoreFileAge overwrites instead of accumulat… - #8572
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes per-table avgStoreFileAge aggregation in RegionServer table metrics so that store-file age totals are accumulated across all stores (instead of being overwritten), and adds a focused unit test to prevent regressions (HBASE-30343).
Changes:
- Accumulate
totalStoreFileAgeacross stores using+=during metrics aggregation. - Add a new unit test validating avg/max/min store file age and store/region counts across multiple regions/stores.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableWrapperAggregateImpl.java |
Fixes store-file age total aggregation to correctly accumulate per-store contributions per table. |
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableWrapperAggregate.java |
Adds regression test ensuring per-table avg store-file age aggregates correctly across multiple stores/regions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
Thanks @guluo2016 for the reviewing! |
liuxiaocs7
added a commit
that referenced
this pull request
Aug 28, 2026
…ing store ages (#8572) Signed-off by: Peng Lu <lupeng@apache.org>
liuxiaocs7
added a commit
that referenced
this pull request
Aug 28, 2026
…ing store ages (#8572) Signed-off by: Peng Lu <lupeng@apache.org>
liuxiaocs7
added a commit
that referenced
this pull request
Aug 28, 2026
…ing store ages (#8572) Signed-off by: Peng Lu <lupeng@apache.org>
liuxiaocs7
added a commit
that referenced
this pull request
Aug 28, 2026
…ing store ages (#8572) Signed-off by: Peng Lu <lupeng@apache.org>
liuxiaocs7
added a commit
that referenced
this pull request
Aug 28, 2026
…ing store ages (#8572) Signed-off by: Peng Lu <lupeng@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing store ages