Skip to content

HDFS-17947. dfs.block.access.token.lifetime=0 can cause DataStreamer createBlockOutputStream failure. #8638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joseluisll wants to merge 3 commits into
base: trunk
Choose a base branch
from
+18 −0
Open

HDFS-17947. dfs.block.access.token.lifetime=0 can cause DataStreamer createBlockOutputStream failure. #8638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
150cd8d
HDFS-17947. dfs.block.access.token.lifetime=0 can cause DataStreamer …
joseluisll Jul 28, 2026
b0ce37d
HDFS-17947. Address review comments.
joseluisll Jul 29, 2026
5bc3661
HDFS-17947. Address review comments.
joseluisll Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,6 +724,11 @@ private static BlockTokenSecretManager createBlockTokenSecretManager(
final long lifetimeMin = conf.getLong(
DFSConfigKeys.DFS_BLOCK_ACCESS_TOKEN_LIFETIME_KEY,
DFSConfigKeys.DFS_BLOCK_ACCESS_TOKEN_LIFETIME_DEFAULT);
if (lifetimeMin <= 0) {
throw new HadoopIllegalArgumentException(
DFSConfigKeys.DFS_BLOCK_ACCESS_TOKEN_LIFETIME_KEY + " = '"
+ lifetimeMin + "' is invalid. It should be a positive value.");
}
Comment thread
joseluisll marked this conversation as resolved.
final String encryptionAlgorithm = conf.get(
DFSConfigKeys.DFS_DATA_ENCRYPTION_ALGORITHM_KEY);
LOG.info("{}={} min(s), {}={} min(s), {}={}",
Expand Down
13 changes: 13 additions & 0 deletions ...fs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,15 @@
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
import java.io.IOException;
import java.net.InetSocketAddress;
import java.net.Socket;
import java.util.List;
import java.util.Random;

import org.apache.hadoop.HadoopIllegalArgumentException;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.CommonConfigurationKeys;
import org.apache.hadoop.fs.FSDataInputStream;
Expand Down Expand Up @@ -222,6 +224,17 @@ protected Configuration getConf(int numDataNodes) {
return conf;
}

@Test
public void testInvalidBlockTokenLifetime() {
for (long lifetime : new long[] {0, -1}) {
Configuration conf = getConf(1);
conf.setLong(DFSConfigKeys.DFS_BLOCK_ACCESS_TOKEN_LIFETIME_KEY, lifetime);
assertThrows(HadoopIllegalArgumentException.class,
() -> new MiniDFSCluster.Builder(conf).numDataNodes(1).build(),
DFSConfigKeys.DFS_BLOCK_ACCESS_TOKEN_LIFETIME_KEY);
}
}

/**
* testing that APPEND operation can handle token expiration when
* re-establishing pipeline is needed
Expand Down
Loading