Skip to content

GUACAMOLE-2232: On-Screen Keyboard: CapsLock gets out-of-sync on macOS.#1176

Open
bbennett-ks wants to merge 1 commit into
apache:mainfrom
bbennett-ks:GUACAMOLE-2232-onscreen-keyboard-capslock-out-of-sync-macos
Open

GUACAMOLE-2232: On-Screen Keyboard: CapsLock gets out-of-sync on macOS.#1176
bbennett-ks wants to merge 1 commit into
apache:mainfrom
bbennett-ks:GUACAMOLE-2232-onscreen-keyboard-capslock-out-of-sync-macos

Conversation

@bbennett-ks

@bbennett-ks bbennett-ks commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • OnBoardKeyBoard.js:
    • Added Key object toggle property.
    • Updated logic to send <keyup><keydown> for each key press for keys with toggle == true.
  • *erty.json:
    • Add toggle = true for <Caps> for all keyboard layouts.

Testing

  • macOS Tahoe (26.3): native browser (Chrome) and Rocky 9 VM Chrome browser
  • Windows 11: native browser (Chrome) and Rocky 9 VM Chrome browser

Comment thread guacamole-common-js/src/main/webapp/modules/OnScreenKeyboard.js Outdated
@bbennett-ks bbennett-ks force-pushed the GUACAMOLE-2232-onscreen-keyboard-capslock-out-of-sync-macos branch 2 times, most recently from cc73657 to d8bf9e2 Compare April 2, 2026 14:56
@bbennett-ks bbennett-ks requested a review from mike-jumper April 2, 2026 14:58
@bbennett-ks bbennett-ks force-pushed the GUACAMOLE-2232-onscreen-keyboard-capslock-out-of-sync-macos branch from d8bf9e2 to ffe3089 Compare April 2, 2026 18:53
@bbennett-ks bbennett-ks force-pushed the GUACAMOLE-2232-onscreen-keyboard-capslock-out-of-sync-macos branch from ffe3089 to ca1a7a2 Compare April 16, 2026 15:50
@necouchman

Copy link
Copy Markdown
Contributor

@bbennett-ks You appear to have either multiple Jira issues or some extra commits, here. I see two for GUACAMOLE-2225 and one for GUACAMOLE-2232.

@bbennett-ks bbennett-ks force-pushed the GUACAMOLE-2232-onscreen-keyboard-capslock-out-of-sync-macos branch from ca1a7a2 to cb9a38d Compare April 22, 2026 13:45
@bbennett-ks

Copy link
Copy Markdown
Contributor Author

@bbennett-ks You appear to have either multiple Jira issues or some extra commits, here. I see two for GUACAMOLE-2225 and one for GUACAMOLE-2232.

Fixed. Thanks!

Comment thread guacamole-common-js/src/main/webapp/modules/OnScreenKeyboard.js Outdated
Comment thread guacamole-common-js/src/main/webapp/modules/OnScreenKeyboard.js Outdated
@bbennett-ks bbennett-ks force-pushed the GUACAMOLE-2232-onscreen-keyboard-capslock-out-of-sync-macos branch from cb9a38d to 8883fbf Compare June 2, 2026 11:42
@bbennett-ks bbennett-ks requested a review from eugen-keeper June 2, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants