[GLUTEN-12022][VL] Extend S3 filesystem registration in Gluten#12026
Open
ReemaAlzaid wants to merge 4 commits intoapache:mainfrom
Open
[GLUTEN-12022][VL] Extend S3 filesystem registration in Gluten#12026ReemaAlzaid wants to merge 4 commits intoapache:mainfrom
ReemaAlzaid wants to merge 4 commits intoapache:mainfrom
Conversation
ReemaAlzaid
force-pushed
the
gluten-s3-filesystem-registration
branch
from
aa80525 to
e627ce1
Compare
philo-he
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#12022
This PR adds a Gluten S3 filesystem registration path for the Velox backend
It introduces
GlutenS3FileSystem, which extends Velox'sS3FileSystem, and registers it fromVeloxBackendwhen Gluten is built with S3 support. The current implementation preserves the existing Velox S3 behavior by delegating writes to Velox's S3 filesystem.Why are the changes needed?
Gluten currently registers Velox's S3 filesystem directly. That makes it hard to customize, debug, or extend S3 behavior from Gluten without changing Velox side registration.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Built the focused C++ test target:
cmake --build cpp/build --target gluten_s3_file_system_test -j 12Ran the new C++ test:
cpp/build/velox/tests/gluten_s3_file_system_test --gtest_filter=GlutenS3FileSystemTest.registeredFileSystemUsesGlutenSubclassManually verified with Spark 4.0.1 and S3A that Gluten registers the custom S3 filesystem, native Parquet write uses the Gluten S3 write path, S3 files are committed successfully, and the Velox S3 read plan is generated.