[server] Update tablet server metadata cache when TableRegistration changed#2378
Merged
wuchong merged 3 commits intoapache:mainfrom Jan 24, 2026
Merged
[server] Update tablet server metadata cache when TableRegistration changed#2378wuchong merged 3 commits intoapache:mainfrom
wuchong merged 3 commits intoapache:mainfrom
Conversation
2d8a64e to
332f5c7
Compare
Jackeyzhe
reviewed
Jan 19, 2026
fluss-server/src/test/java/org/apache/fluss/server/log/remote/RemoteLogITCase.java
Outdated
Show resolved
Hide resolved
332f5c7 to
099d37b
Compare
Jackeyzhe
approved these changes
Jan 20, 2026
Contributor
Jackeyzhe
left a comment
There was a problem hiding this comment.
Thanks for this PR, it looks good to me.
luoyuxia
reviewed
Jan 21, 2026
Contributor
luoyuxia
left a comment
There was a problem hiding this comment.
@LiebingYu Thanks for the pr. Left minor comment. PTAL.
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorEventProcessor.java
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/replica/ReplicaManager.java
Outdated
Show resolved
Hide resolved
fluss-server/src/test/java/org/apache/fluss/server/log/remote/RemoteLogITCase.java
Outdated
Show resolved
Hide resolved
099d37b to
2c759d3
Compare
luoyuxia
approved these changes
Jan 23, 2026
Contributor
luoyuxia
left a comment
There was a problem hiding this comment.
@LiebingYu Thanks for update. LGTM! @wuchong Could you please help review again?
wuchong
approved these changes
Jan 24, 2026
Member
wuchong
left a comment
There was a problem hiding this comment.
I pushed a commit to improve the code. Will merge the PR once CI is passed.
| long tableId = tableInfo.getTableId(); | ||
| boolean dataLakeEnabled = tableInfo.getTableConfig().isDataLakeEnabled(); | ||
|
|
||
| for (Map.Entry<TableBucket, HostedReplica> entry : allReplicas.entrySet()) { |
Member
There was a problem hiding this comment.
nit: The complexity is O(M x N) where M is the number of TableMetadata, and N is the number of Replicas. We can improve the complexity to O(M+N).
rionmonster
pushed a commit
to rionmonster/fluss
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2375
Brief change log
Tests
API and Format
Documentation